Skip to content

Fix missing_inline_in_public_items fail to fulfill expect in --test build #15320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix missing_inline_in_public_items fail to fulfill expect in --test build #15320

wants to merge 2 commits into from

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jul 21, 2025 •
edited by rustbot
Loading

Closes #13394

changelog: [missing_inline_in_public_items] fix failure to fulfill expect in --test build

@rustbot
Copy link
Collaborator

rustbot commented Jul 21, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 21, 2025
@profetia profetia force-pushed the issue13394 branch 2 times, most recently from c1a51b3 to e528256 Compare July 21, 2025 15:04
y21
y21 reviewed Jul 24, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does mean that something like #[expect(clippy::missing_inline_in_public_items)] fn private_function() {} passes the expectation with --test even though the lint would never emit a warning there, but I'm not really sure how we could avoid that so this seems fine

@Alexendoo
Copy link
Member

This looks like a symptom rather than the root of the issue, that the following is a false negative when ran with cargo clippy --tests

#![warn(clippy::missing_inline_in_public_items)]

pub fn foo() -> u32 {
    0
}

It should still lint foo as it would for cargo clippy

@profetia
Copy link
Contributor Author

Hmm.. Im confused. What is the expected behavior in --test ?

@profetia
Copy link
Contributor Author

I doubt if it is possible to know the original crate type in --test

@profetia profetia requested a review from y21 July 27, 2025 07:15
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned Jarcho and unassigned y21 Aug 11, 2025
@Alexendoo
Copy link
Member

I doubt if it is possible to know the original crate type in --test

Yeah I think that might well be the case

Something we could do is remove the is_executable_or_proc_macro check entirely, it would be a useless warning for bin crates but as it's a restriction lint that should be okay

@profetia
Copy link
Contributor Author

Updated. Check for executables are now removed

@github-actions GitHub Actions
Copy link

Lintcheck changes for 6a142ba

Lint Added Removed Changed
clippy::missing_inline_in_public_items 10 0 0

This comment will be updated if you push new changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 Awaiting requested review from y21

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In test builds, expect(clippy::missing_inline_in_public_items) does not function properly
5 participants
@profetia @rustbot @Alexendoo @y21 @Jarcho